-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(learn): Revise Angular tutorial for v17 #32701
Conversation
...s/learn/tools_and_testing/client-side_javascript_frameworks/angular_getting_started/index.md
Outdated
Show resolved
Hide resolved
...s/learn/tools_and_testing/client-side_javascript_frameworks/angular_getting_started/index.md
Outdated
Show resolved
Hide resolved
A few more changes. In Angular_getting_started, the angular doesn't support current version it seems only LTS versions are supported. So the statement needs to be
May I get edit permissions to |
Nice one, thanks for spotting.
Sure! I've sent you an invite for my fork, you should get access 🙌🏻 |
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
42ccb30
to
7770ed2
Compare
The -- <li *ngFor="let item of items">{{item.description}}</li>
++ @for (item of items) {
++ <li>{{item.description}}</li>
++ } |
I like how it looks, they're in "developer preview" - shall we update this when they're "stable"? Angular 18 is on the way, so maybe we hold off on these types of changes until then. |
Around two months from now. Let's add the new stuff after that. |
Sounds good to me! Are your changes ready to land? I think we can merge shortly |
Yes |
Thanks @OnkarRuikar - do you want to leave a review so we can merge (no author self-approval)? |
I don't have approve rights in this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor tweaks and a suggestion. Otherwise, looks good to me :) Thanks!
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/angular_building/index.md
Outdated
Show resolved
Hide resolved
...s/learn/tools_and_testing/client-side_javascript_frameworks/angular_getting_started/index.md
Outdated
Show resolved
Hide resolved
...arn/tools_and_testing/client-side_javascript_frameworks/angular_todo_list_beginning/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Vadim Makeev <hi@pepelsbey.dev>
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/angular_building/index.md
Outdated
Show resolved
Hide resolved
…meworks/angular_building/index.md
files/en-us/learn/tools_and_testing/client-side_javascript_frameworks/angular_building/index.md
Outdated
Show resolved
Hide resolved
…meworks/angular_building/index.md
Thanks, both - going to merge shortly! |
Description
There were some errors in the Angular tutorial and some fixes have landed, but there was a need to follow through the steps again from the beginning to make sure everything works as expected.
This PR uses 17.3.0 (current when using
npm install -g @angular/cli
at time of writing).Motivation
Keeping the tutorials using frameworks error-free at the very least.
Related issues and pull requests